linux-kernel - Re: [PATCH] selftests: proc: remove unreached code and fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 20:25:31 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Amer Al Shanawany <amer.shanawany@...il.com>, Shuah Khan
 <shuah@...nel.org>, Swarup Laxman Kotiaklapudi
 <swarupkotikalapudi@...il.com>, Hugh Dickins <hughd@...gle.com>,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] selftests: proc: remove unreached code and fix build
 warning

On Mon, 3 Jun 2024 17:24:47 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:

> On Mon, Jun 03, 2024 at 02:42:20PM +0200, Amer Al Shanawany wrote:
> > fix the following warning:
> > proc-empty-vm.c:385:17: warning: ignoring return value of ‘write’
> 
> > --- a/tools/testing/selftests/proc/proc-empty-vm.c
> > +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> > @@ -381,9 +381,6 @@ static int test_proc_pid_statm(pid_t pid)
> 
> > -	if (0) {
> > -		write(1, buf, rv);
> > -	}
> 
> no thanks

Why not?

Why does that code exist anyway?  It at least needs a comment.