linux-kernel - Re: [PATCH] lib/Kconfig.debug: document panic= command line option for PANIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmCqOS8xgSAY7bRa@x1>
Date: Wed, 5 Jun 2024 14:11:05 -0400
From: Brian Masney <bmasney@...hat.com>
To: Javier Martinez Canillas <javierm@...hat.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/Kconfig.debug: document panic= command line option
 for PANIC_TIMEOUT

On Wed, Jun 05, 2024 at 08:05:23PM +0200, Javier Martinez Canillas wrote:
> Brian Masney <bmasney@...hat.com> writes:
> 
> Hello Brian,
> 
> > PANIC_TIMEOUT can also be controlled with the panic= kernel command line
> > option, so let's reference it in the Kconfig help. This option is already
> > documented in kernel-parameters.txt.
> >
> > Signed-off-by: Brian Masney <bmasney@...hat.com>
> > ---
> >  lib/Kconfig.debug | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 59b6765d86b8..a6eb7425b888 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
> >  	  Set the timeout value (in seconds) until a reboot occurs when
> >  	  the kernel panics. If n = 0, then we wait forever. A timeout
> >  	  value n > 0 will wait n seconds before rebooting, while a timeout
> > -	  value n < 0 will reboot immediately.
> > +	  value n < 0 will reboot immediately. The kernel command line
> > +	  option panic= may be used to override this option.
> >  
> 
> Thanks for adding this, I wasn't aware of that panic= cmdline before.
> 
> Maybe it could also be mentioned that the timeout can be overriden by
> user-space using the /proc/sys/kernel/panic sysfs entry too ?
> 
> Regardless, the patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

I can add that. I'll wait a few days send a v2 to see if there's any
other feedback.

Brian