linux-kernel - Re: [PATCH 1/3] x86/fpu: Make task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <204e541d-ff48-487c-8f70-619f90f65635@intel.com>
Date: Wed, 5 Jun 2024 12:04:35 -0700
From: "Chang S. Bae" <chang.seok.bae@...el.com>
To: Ingo Molnar <mingo@...nel.org>, <linux-kernel@...r.kernel.org>
CC: Andy Lutomirski <luto@...capital.net>, Andrew Morton
	<akpm@...ux-foundation.org>, Dave Hansen <dave@...1.net>, Peter Zijlstra
	<peterz@...radead.org>, Borislav Petkov <bp@...en8.de>, "H . Peter Anvin"
	<hpa@...or.com>, Linus Torvalds <torvalds@...ux-foundation.org>, "Oleg
 Nesterov" <oleg@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, "Uros
 Bizjak" <ubizjak@...il.com>
Subject: Re: [PATCH 1/3] x86/fpu: Make task_struct::thread constant size

On 6/5/2024 1:35 AM, Ingo Molnar wrote:
>   
>   /*
>    * Handler for when we fail to restore a task's FPU state.  We should never get
> - * here because the FPU state of a task using the FPU (task->thread.fpu.state)
> + * here because the FPU state of a task using the FPU (task->thread.fpu->state)

Just a nitpick:
	fpu::fpstate now points to the active FPU in-memory storage.

Thanks,
Chang