linux-kernel - [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605035617.2189393-1-danishanwar@ti.com>
Date: Wed, 5 Jun 2024 09:26:17 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Diogo Ivo
	<diogo.ivo@...mens.com>, Andrew Lunn <andrew@...n.ch>,
        Roger Quadros
	<rogerq@...nel.org>,
        MD Danish Anwar <danishanwar@...com>, Paolo Abeni
	<pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
	<edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>
CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <srk@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        kernel test robot <lkp@...el.com>,
        Thorsten Leemhuis <linux@...mhuis.info>
Subject: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH_SR1

icssg_config.c uses some APIs that are defined in icssg_queue.c.
TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
result the below build error is seen

ERROR: modpost: "icssg_queue_pop"
[drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
ERROR: modpost: "icssg_queue_push"
[drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!

Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405182038.ncf1mL7Z-lkp@intel.com/
Fixes: 487f7323f39a ("net: ti: icssg-prueth: Add helper functions to configure FDB")
Signed-off-by: MD Danish Anwar <danishanwar@...com>
---
Cc: Thorsten Leemhuis <linux@...mhuis.info>

NOTE: This is only applicable on net-next but not on net as the patch that
introduced this dependency is part of net-next.

 drivers/net/ethernet/ti/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile
index 59cd20a38267..79464ad6f1e8 100644
--- a/drivers/net/ethernet/ti/Makefile
+++ b/drivers/net/ethernet/ti/Makefile
@@ -45,6 +45,7 @@ obj-$(CONFIG_TI_ICSSG_PRUETH_SR1) += icssg-prueth-sr1.o
 icssg-prueth-sr1-y := icssg/icssg_prueth_sr1.o \
 		      icssg/icssg_common.o \
 		      icssg/icssg_classifier.o \
+		      icssg/icssg_queues.o \
 		      icssg/icssg_config.o \
 		      icssg/icssg_mii_cfg.o \
 		      icssg/icssg_stats.o \

base-commit: cd0057ad75116bacf16fea82e48c1db642971136
-- 
2.34.1