linux-kernel - Re: [RFC PATCH v5 00/29] TDX KVM selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c3abac8c28310916651a25c30277fc1efbad56f.camel@intel.com>
Date: Wed, 5 Jun 2024 20:18:37 +0000
From: "Verma, Vishal L" <vishal.l.verma@...el.com>
To: "sagis@...gle.com" <sagis@...gle.com>
CC: "vipinsh@...gle.com" <vipinsh@...gle.com>, "Aktas, Erdem"
	<erdemaktas@...gle.com>, "shuah@...nel.org" <shuah@...nel.org>, "Xu, Haibo1"
	<haibo1.xu@...el.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "Afranji,
 Ryan" <afranji@...gle.com>, "dmatlack@...gle.com" <dmatlack@...gle.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"ackerleytng@...gle.com" <ackerleytng@...gle.com>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"jmattson@...gle.com" <jmattson@...gle.com>, "Annapurve, Vishal"
	<vannapurve@...gle.com>, "runanwang@...gle.com" <runanwang@...gle.com>,
	"Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
	"pgonda@...gle.com" <pgonda@...gle.com>
Subject: Re: [RFC PATCH v5 00/29] TDX KVM selftests

On Wed, 2024-06-05 at 20:15 +0000, Verma, Vishal L wrote:
> On Wed, 2024-06-05 at 15:10 -0500, Sagi Shahar wrote:
> > On Wed, Jun 5, 2024 at 1:38 PM Verma, Vishal L <vishal.l.verma@...el.com> wrote:
> > > 
> > > On Tue, 2023-12-12 at 12:46 -0800, Sagi Shahar wrote:
> > > > Hello,
> > > > 
> > > > This is v4 of the patch series for TDX selftests.
> > > > 
> > > > It has been updated for Intel’s v17 of the TDX host patches which was
> > > > proposed here:
> > > > https://lore.kernel.org/all/cover.1699368322.git.isaku.yamahata@intel.com/
> > > > 
> > > > The tree can be found at:
> > > > https://github.com/googleprodkernel/linux-cc/tree/tdx-selftests-rfc-v5
> > > 
> > > Hello,
> > > 
> > > I wanted to check if there were any plans from Google to refresh this
> > > series for the current TDX patches and the kvm-coco-queue baseline?
> > > 
> > I'm going to work on it soon and was planning on using Isaku's V19 of
> > the TDX host patches
> 
> That's great, thank you!
> 
> > 
> > > I'm setting up a CI system that the team is using to test updates to
> > > the different TDX patch series, and it currently runs the KVM Unit
> > > tests, and kvm selftests, and we'd like to be able to add these three
> > > new TDX tests to that as well.
> > > 
> > > I tried to take a quick shot at rebasing it, but ran into several
> > > conflicts since kvm-coco-queue has in the meantime made changes e.g. in
> > > tools/testing/selftests/kvm/lib/x86_64/processor.c vcpu_setup().
> > > 
> > > If you can help rebase this, Rick's MMU prep series might be a good
> > > baseline to use:
> > > https://lore.kernel.org/all/20240530210714.364118-1-rick.p.edgecombe@intel.com/
> > 
> > This patch series only includes the basic TDX MMU changes and is
> > missing a lot of the TDX support. Not sure how this can be used as a
> > baseline without the rest of the TDX patches. Are there other patch
> > series that were posted based on this series which provides the rest
> > of the TDX support?
> 
> Hm you're right, I was looking more narrowly because of the kvm-coco-
> queue conflicts, for some of which even v19 might be too old. The MMU
> prep series uses a much more recent kvm-coco-queue baseline.
> 
> Rick, can we post a branch with /everything/ on this MMU prep baseline
> for this selftest refresh?

Actually I see the branch below does contain everything, not just the
MMU prep patches. Sagi, is this fine for a baseline?

> 
> > > 
> > > This is also available in a tree at:
> > > https://github.com/intel/tdx/tree/tdx_kvm_dev-2024-05-30
> > > 
> > > >