linux-kernel - Re: [PATCH v2] PCI/AER: Print error message as per the TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605215848.GA782210@bhelgaas>
Date: Wed, 5 Jun 2024 16:58:48 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Abhinav Jain <jain.abhinav177@...il.com>
Cc: bhelgaas@...gle.com, javier.carrasco.cruz@...il.com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, mahesh@...ux.ibm.com,
	oohall@...il.com, skhan@...uxfoundation.org
Subject: Re: [PATCH v2] PCI/AER: Print error message as per the TODO

On Wed, Jun 05, 2024 at 09:23:44PM +0000, Abhinav Jain wrote:
> Print the add device error in find_device_iter()
> 
> Signed-off-by: Abhinav Jain <jain.abhinav177@...il.com>
> 
> PATCH v1 link : https://lore.kernel.org/all/20240415161055.8316-1-jain.abhinav177@gmail.com/
> 
> Changes since v1:
>  - Replaced pr_err() with pr_notice()
>  - Removed unncessary whitespaces
> ---

Thanks for looking at this.

  - It doesn't apply to -rc1 (the TODO message is missing).  In PCI,
    we normally apply patches on topic branches based on -rc1.

  - The subject should be more specific so it makes sense all by
    itself, e.g., "Log note if we find too many devices with errors"

  - Add period at end of sentence in commit log.

  - Move historical notes (v1 URL, changes since v1) below the "---"
    line so they don't get included in the commit log.

  - __func__ is not relevant here -- that's generally a debugging
    thing.  We can find the function by searching for the message
    text.  In cases like this, I'd rather have something that helps
    identify a *device* that's related to the message, e.g., the
    pci_dev in this case.  So I'd suggest pci_err(dev, "...") here.

  - I'd keep pci_err() instead of switching to pr_notice().  If we get
    this message, we should re-think the way we collect this
    information, so I want to hear about it.

>  drivers/pci/pcie/aer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 0e1ad2998116..8b820a74dd6b 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -885,8 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void *data)
>  		/* List this device */
>  		if (add_error_device(e_info, dev)) {
>  			/* We cannot handle more... Stop iteration */
> -			pr_err("find_device_iter: Cannot handle more devices.
> -					Stopping iteration");
> +			pr_notice("%s: Cannot handle more devices - iteration stopped\n",
> +					__func__);
>  			return 1;
>  		}
>  
> -- 
> 2.34.1
>