linux-kernel - Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bc38042-7034-4937-a2e6-2dcfd8c2d609@linaro.org>
Date: Wed, 5 Jun 2024 09:15:07 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nathan Morrisson <nmorrisson@...tec.com>, catalin.marinas@....com,
 will@...nel.org, quic_bjorande@...cinc.com, geert+renesas@...der.be,
 konrad.dybcio@...aro.org, shawnguo@...nel.org, neil.armstrong@...aro.org,
 arnd@...db.de, m.szyprowski@...sung.com, nfraprado@...labora.com,
 u-kumar1@...com
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 upstream@...ts.phytec.de, w.egorov@...tec.de
Subject: Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC

On 05/06/2024 01:38, Nathan Morrisson wrote:
> Enable the TI LP873X PMIC configs.

Why? No user of this, sorry. Please explain in commit msg why this
should be done, e.g. which upstream user needs it.

> 
> Signed-off-by: Nathan Morrisson <nmorrisson@...tec.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 57a9abe78ee4..24ea62a8fdbf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
>  CONFIG_MFD_SL28CPLD=y
>  CONFIG_RZ_MTU3=y
>  CONFIG_MFD_TI_AM335X_TSCADC=m
> +CONFIG_MFD_TI_LP873X=y

Why this cannot be m?

>  CONFIG_MFD_TPS65219=y
>  CONFIG_MFD_TPS6594_I2C=m
>  CONFIG_MFD_ROHM_BD718XX=y
> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
>  CONFIG_REGULATOR_GPIO=y
>  CONFIG_REGULATOR_HI6421V530=y
>  CONFIG_REGULATOR_HI655X=y
> +CONFIG_REGULATOR_LP873X=y

Why this cannot be m?

>  CONFIG_REGULATOR_MAX77620=y
>  CONFIG_REGULATOR_MAX8973=y
>  CONFIG_REGULATOR_MAX20411=m

Best regards,
Krzysztof