linux-kernel - Re: [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmEBn2E1FPKiXnMc@pengfei-OptiPlex-Tower-Plus-7010>
Date: Wed, 5 Jun 2024 17:23:59 -0700
From: Pengfei Li <pengfei.li_1@....com>
To: Rob Herring <robh@...nel.org>
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, abelvesa@...nel.org,
	mturquette@...libre.com, sboyd@...nel.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	ping.bai@....com, ye.li@....com, peng.fan@....com,
	aisheng.dong@....com, frank.li@....com, tharvey@...eworks.com,
	alexander.stein@...tq-group.com, gregor.herburger@...tq-group.com,
	hiago.franco@...adex.com, joao.goncalves@...adex.com,
	hvilleneuve@...onoff.com, Markus.Niebel@...tq-group.com,
	m.felsch@...gutronix.de, m.othacehe@...il.com, bhelgaas@...gle.com,
	leoyang.li@....com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition

On Tue, Jun 04, 2024 at 10:04:47AM -0500, Rob Herring wrote:
> On Wed, May 29, 2024 at 07:26:31PM -0700, Pengfei Li wrote:
> > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
> > Add i.MX91 related clock definition.
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> >  include/dt-bindings/clock/imx93-clock.h | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
> > index 787c9e74dc96..ca0785f35a46 100644
> > --- a/include/dt-bindings/clock/imx93-clock.h
> > +++ b/include/dt-bindings/clock/imx93-clock.h
> > @@ -204,6 +204,11 @@
> >  #define IMX93_CLK_A55_SEL		199
> >  #define IMX93_CLK_A55_CORE		200
> >  #define IMX93_CLK_PDM_IPG		201
> > -#define IMX93_CLK_END			202
> > +#define IMX91_CLK_ENET1_QOS_TSN     202
> > +#define IMX91_CLK_ENET_TIMER        203
> > +#define IMX91_CLK_ENET2_REGULAR     204
> > +#define IMX91_CLK_ENET2_REGULAR_GATE		205
> > +#define IMX91_CLK_ENET1_QOS_TSN_GATE		206
> > +#define IMX93_CLK_END			207
> 
> Drop the END define. If it can change, it's not part of the ABI.
> 
> Rob
> 

Hi Rob Herring,

The 'IMX93_CLK_END' macro definition is indeed not a certain clock, but it is
used in the imx93 ccm driver to indicate the number of clocks. And this macro
already existed before this patch, so it may not be able to be deleted.

BR,
Pengfei Li