linux-kernel - Re: [PATCH] RAS/AMD/ATL: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605094051.GDZmAyo1-j_uBri_YO@fat_crate.local>
Date: Wed, 5 Jun 2024 11:40:51 +0200
From: Borislav Petkov <bp@...en8.de>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Yazen Ghannam <Yazen.Ghannam@....com>, Tony Luck <tony.luck@...el.com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] RAS/AMD/ATL: add missing MODULE_DESCRIPTION() macro

On Tue, Jun 04, 2024 at 07:21:59PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ras/amd/atl/amd_atl.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  drivers/ras/amd/atl/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
> index 6dc4e06305f7..7be4982fdf19 100644
> --- a/drivers/ras/amd/atl/core.c
> +++ b/drivers/ras/amd/atl/core.c
> @@ -222,4 +222,5 @@ static void __exit amd_atl_exit(void)
>  module_init(amd_atl_init);
>  module_exit(amd_atl_exit);
>  
> +MODULE_DESCRIPTION("AMD Address Translation Library");
>  MODULE_LICENSE("GPL");
> 
> ---

Applied, thanks.

Btw, I'd suggest instead of sending those piecemeal-wise, one per
driver, just group them all by subsystem and whatnot so that each
maintainer can pick it up and this new thing modpost decided to complain
about, can be taken care of without noodling through each driver
one-by-one.

Better yet: do a coccinelle patch and convert the whole tree.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette