[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZmAzY4eE9eaJ0IpE@Laptop-X1>
Date: Wed, 5 Jun 2024 17:44:03 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Cc: mptcp@...ts.linux.dev, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Shuah Khan <shuah@...nel.org>, Petr Machata <petrm@...dia.com>,
netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Geliang Tang <geliang@...nel.org>
Subject: Re: [PATCH net 1/3] selftests: net: lib: support errexit with
busywait
On Wed, Jun 05, 2024 at 11:21:16AM +0200, Matthieu Baerts (NGI0) wrote:
> If errexit is enabled ('set -e'), loopy_wait -- or busywait and others
> using it -- will stop after the first failure.
>
> Note that if the returned status of loopy_wait is checked, and even if
> errexit is enabled, Bash will not stop at the first error.
>
> Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Not sure if the fixes tag should be c5341bcc337c ("selftests: mlxsw: Add a
self-test for port-default priority"), so the fixes could be backported to
stable kernel for forwarding/lib.sh. Others looks good to me.
Reviewed-by: Hangbin Liu <liuhangbin@...il.com>
> Cc: stable@...r.kernel.org
> Acked-by: Geliang Tang <geliang@...nel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> ---
> tools/testing/selftests/net/lib.sh | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh
> index edc030e81a46..a422e10d3d3a 100644
> --- a/tools/testing/selftests/net/lib.sh
> +++ b/tools/testing/selftests/net/lib.sh
> @@ -67,9 +67,7 @@ loopy_wait()
> while true
> do
> local out
> - out=$("$@")
> - local ret=$?
> - if ((!ret)); then
> + if out=$("$@"); then
> echo -n "$out"
> return 0
> fi
>
> --
> 2.43.0
>
Powered by blists - more mailing lists