linux-kernel - Re: [PATCH linux-next] printk: nbcon: Fix nbcon_cpu_emergency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmA6oGrO1YVF-IYj@pathway.suse.cz>
Date: Wed, 5 Jun 2024 12:14:56 +0200
From: Petr Mladek <pmladek@...e.com>
To: Juri Lelli <juri.lelli@...hat.com>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	John Ogness <john.ogness@...utronix.de>
Subject: Re: [PATCH linux-next] printk: nbcon: Fix
 nbcon_cpu_emergency_flush() when preemptible

On Wed 2024-06-05 12:10:50, Petr Mladek wrote:
> On Wed 2024-06-05 11:57:34, John Ogness wrote:
> > nbcon_cpu_emergency_flush() can be called in a preemptible
> > context. In that case the CPU is not in an emergency state.
> > However, in order to see that the CPU is not in an emergency
> > state (accessing the per-cpu variable), preemption must be
> > disabled.
> > 
> > Disable preemption when checking the CPU state.
> > 
> > Reported-by: Juri Lelli <juri.lelli@...hat.com>
> > Closes: https://lore.kernel.org/aqkcpca4vgadxc3yzcu74xwq3grslj5m43f3eb5fcs23yo2gy4@gcsnqcts5tos
> > Fixes: 46a1379208b7 ("printk: nbcon: Implement emergency sections")
> > Signed-off-by: John Ogness <john.ogness@...utronix.de>
> 
> Great catch!
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> 
> I am going to push it...

Juri, should/could I add your Tested-by ?

Best Regards,
Petr