linux-kernel - Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the aw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 12:22:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: wangshuaijie@...nic.com, dmitry.torokhov@...il.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, jeff@...undy.com,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: liweilei@...nic.com, kangjiajun@...nic.com
Subject: Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the
 aw_sar driver.

On 05/06/2024 11:11, wangshuaijie@...nic.com wrote:
> From: shuaijie wang <wangshuaijie@...nic.com>
> 

No commit msg, no proper subject prefix.

> Signed-off-by: shuaijie wang <wangshuaijie@...nic.com>
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> | Reported-by: Dan Carpenter <error27@...il.com>

Drop all these, this is some bogus tags. Tag never starts with pipe, btw.

> ---
>  drivers/input/misc/aw_sar/aw9610x/aw9610x.c | 884 ++++++++++++++++++++
>  drivers/input/misc/aw_sar/aw9610x/aw9610x.h | 327 ++++++++
>  2 files changed, 1211 insertions(+)
>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.c
>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.h

...

> +struct aw_reg_data {
> +	unsigned char rw;
> +	unsigned short reg;
> +};
> +/********************************************
> + * Register Access
> + *******************************************/
> +#define REG_NONE_ACCESS					(0)
> +#define REG_RD_ACCESS					(1 << 0)
> +#define REG_WR_ACCESS					(1 << 1)
> +
> +static const struct aw_reg_data g_aw9610x_reg_access[] = {

Ehh... so we are at basics of C. Data structures do not go to headers.

Best regards,
Krzysztof