linux-kernel - Re: [PATCH v2] resource: add a simple test for walk_iomem_res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmA88rFW1ZxbgJSh@smile.fi.intel.com>
Date: Wed, 5 Jun 2024 13:24:50 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Chia-I Wu <olvaffe@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] resource: add a simple test for walk_iomem_res_desc()

On Tue, Jun 04, 2024 at 03:01:14PM -0700, Chia-I Wu wrote:
> This mainly tests that find_next_iomem_res() does not miss resources.

...

It's better, but still hard to follow, see below what I meant

> +	res[0] = DEFINE_RES_NAMED(root.start, SZ_1K, "SYSRAM 1",
> +			IORESOURCE_SYSTEM_RAM);
> +	res[1] = DEFINE_RES_NAMED(root.start + SZ_1K, SZ_1K, "OTHER", 0);
> +
> +	res[2] = DEFINE_RES_NAMED(root.start + SZ_1K * 3, SZ_1K, "NESTED", 0);
> +	res[3] = DEFINE_RES_NAMED(root.start + SZ_1K * 3 + SZ_512, SZ_512,
> +			"SYSRAM 2", IORESOURCE_SYSTEM_RAM);
> +
> +	res[4] = DEFINE_RES_NAMED(root.start + SZ_1K * 4, SZ_1K, "SYSRAM 3",
> +			IORESOURCE_SYSTEM_RAM);

	res[0] = DEFINE_RES_NAMED(root.start + 0x0000, 0x0400, "SYSRAM 1",
				  IORESOURCE_SYSTEM_RAM);
	res[1] = DEFINE_RES_NAMED(root.start + 0x0400, 0x0400, "OTHER", 0);

	res[2] = DEFINE_RES_NAMED(root.start + 0x0c00, 0x0400, "NESTED", 0);
	res[3] = DEFINE_RES_NAMED(root.start + 0x0e00, 0x0200, "SYSRAM 2",
				  IORESOURCE_SYSTEM_RAM);

	res[4] = DEFINE_RES_NAMED(root.start + 0x1000, 0x0400, "SYSRAM 3",
				  IORESOURCE_SYSTEM_RAM);

Also pay attention to indentation.

-- 
With Best Regards,
Andy Shevchenko