linux-kernel - Re: [PATCH] ALSA: hda/senarytech: add senarytech codec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 19:28:30 +0800
From: kernel test robot <lkp@...el.com>
To: bo liu <bo.liu@...arytech.com>, perex@...ex.cz, tiwai@...e.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, bo liu <bo.liu@...arytech.com>
Subject: Re: [PATCH] ALSA: hda/senarytech: add senarytech codec support

Hi bo,

kernel test robot noticed the following build errors:

[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus linus/master v6.10-rc2 next-20240605]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/bo-liu/ALSA-hda-senarytech-add-senarytech-codec-support/20240603-181658
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20240603093429.25511-1-bo.liu%40senarytech.com
patch subject: [PATCH] ALSA: hda/senarytech: add senarytech codec support
config: sparc64-randconfig-r081-20240605 (https://download.01.org/0day-ci/archive/20240605/202406051902.R67SGht9-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406051902.R67SGht9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406051902.R67SGht9-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/pci/hda/patch_senarytech.c: In function 'patch_senary_auto':
>> sound/pci/hda/patch_senarytech.c:219:43: error: macro "senary_auto_parse_beep" passed 1 arguments, but takes just 0
     219 |         err = senary_auto_parse_beep(codec);
         |                                           ^
   sound/pci/hda/patch_senarytech.c:76: note: macro "senary_auto_parse_beep" defined here
      76 | #define senary_auto_parse_beep()        0
         | 
>> sound/pci/hda/patch_senarytech.c:219:15: error: 'senary_auto_parse_beep' undeclared (first use in this function); did you mean 'senary_auto_parse_eapd'?
     219 |         err = senary_auto_parse_beep(codec);
         |               ^~~~~~~~~~~~~~~~~~~~~~
         |               senary_auto_parse_eapd
   sound/pci/hda/patch_senarytech.c:219:15: note: each undeclared identifier is reported only once for each function it appears in


vim +/senary_auto_parse_beep +219 sound/pci/hda/patch_senarytech.c

   191	
   192	static int patch_senary_auto(struct hda_codec *codec)
   193	{
   194		struct senary_spec *spec;
   195		int err;
   196	
   197		codec_info(codec, "%s: BIOS auto-probing.\n", codec->core.chip_name);
   198	
   199		spec = kzalloc(sizeof(*spec), GFP_KERNEL);
   200		if (!spec)
   201			return -ENOMEM;
   202		snd_hda_gen_spec_init(&spec->gen);
   203		codec->spec = spec;
   204		codec->patch_ops = senary_auto_patch_ops;
   205	
   206		senary_auto_parse_eapd(codec);
   207		spec->gen.own_eapd_ctl = 1;
   208	
   209		if (!spec->gen.vmaster_mute.hook && spec->dynamic_eapd)
   210			spec->gen.vmaster_mute.hook = senary_auto_vmaster_hook;
   211	
   212		snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_PRE_PROBE);
   213	
   214		err = snd_hda_parse_pin_defcfg(codec, &spec->gen.autocfg, NULL,
   215					       spec->parse_flags);
   216		if (err < 0)
   217			goto error;
   218	
 > 219		err = senary_auto_parse_beep(codec);
   220		if (err < 0)
   221			goto error;
   222	
   223		err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg);
   224		if (err < 0)
   225			goto error;
   226	
   227		/* Some laptops with Senary chips show stalls in S3 resume,
   228		 * which falls into the single-cmd mode.
   229		 * Better to make reset, then.
   230		 */
   231		if (!codec->bus->core.sync_write) {
   232			codec_info(codec,
   233				   "Enable sync_write for stable communication\n");
   234			codec->bus->core.sync_write = 1;
   235			codec->bus->allow_bus_reset = 1;
   236		}
   237	
   238		snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_PROBE);
   239	
   240		return 0;
   241	
   242	 error:
   243		senary_auto_free(codec);
   244		return err;
   245	}
   246	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki