linux-kernel - Re: [PATCH 4/5] ftrace: Convert "filter_hash" and "inc" to bool in ftrace_hash_rec_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 21:57:11 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: kernel test robot <lkp@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, Masami Hiramatsu
 <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Linux Memory Management List
 <linux-mm@...ck.org>
Subject: Re: [PATCH 4/5] ftrace: Convert "filter_hash" and "inc" to bool in
 ftrace_hash_rec_update_modify()

On Wed, 5 Jun 2024 09:12:57 +0800
kernel test robot <lkp@...el.com> wrote:

> >> kernel/trace/ftrace.c:1961:13: error: conflicting types for 'ftrace_hash_rec_disable_modify'  
>     1961 | static void ftrace_hash_rec_disable_modify(struct ftrace_ops *ops,
>          |             ^
>    kernel/trace/ftrace.c:1384:1: note: previous declaration is here
>     1384 | ftrace_hash_rec_disable_modify(struct ftrace_ops *ops, int filter_hash);
>          | ^
> >> kernel/trace/ftrace.c:1967:13: error: conflicting types for 'ftrace_hash_rec_enable_modify'  
>     1967 | static void ftrace_hash_rec_enable_modify(struct ftrace_ops *ops,

Of course these static functions have prototypes to be used earlier. Bah!

-- Steve