linux-kernel - Re: [PATCH] selftests: arm64: Fix redundancy of a testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 13:00:48 +0100
From: Mark Brown <broonie@...nel.org>
To: Dev Jain <dev.jain@....com>
Cc: linux-arm-kernel@...ts.infradead.org, catalin.marinas@....com,
	will@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org, suzuki.poulose@....com,
	Anshuman.Khandual@....com
Subject: Re: [PATCH] selftests: arm64: Fix redundancy of a testcase

On Wed, Jun 05, 2024 at 05:24:48PM +0530, Dev Jain wrote:
> Currently, we are writing the same value as we read, into the TLS
> register; hence, we cannot confirm updation of the register, making the
> testcase "verify_tpidr_one" redundant. Fix this; while at it, do a style
> change.

Please don't combine unrelated changes into a single patch.

>  	/* ...write a new value.. */
>  	write_iov.iov_len = sizeof(uint64_t);
> -	write_val[0] = read_val[0]++;
> +	write_val[0] = read_val[0] + 1;
>  	ret = ptrace(PTRACE_SETREGSET, child, NT_ARM_TLS, &write_iov);
>  	ksft_test_result(ret == 0, "write_tpidr_one\n");

This is a good fix:

Reviewed-by: Mark Brown <broonie@...nel.org>

> @@ -108,7 +108,7 @@ static void test_tpidr(pid_t child)
>  		/* Writing only TPIDR... */
>  		write_iov.iov_len = sizeof(uint64_t);
>  		memcpy(write_val, read_val, sizeof(read_val));
> -		write_val[0] += 1;
> +		++write_val[0];

I'm less convinced that this is a good style change.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)