linux-kernel - Re: [PATCH] ASoC: dt-binding: convert amlogic,g12a-tohdmitx to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05454339-9f83-4101-ac55-0dc7b5a8d45e@kernel.org>
Date: Thu, 6 Jun 2024 09:45:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>,
 Jerome Brunet <jbrunet@...libre.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-binding: convert amlogic,g12a-tohdmitx to
 dt-schema

On 05/06/2024 18:23, Neil Armstrong wrote:
> Convert text bindings to dt-schema format for the Amlogic TX HDMI
> control glue.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>

subject: dt-bindings (missing 's')

> ---
>  .../bindings/sound/amlogic,g12a-tohdmitx.txt       | 58 ----------------------
>  .../bindings/sound/amlogic,g12a-tohdmitx.yaml      | 56 +++++++++++++++++++++
>  2 files changed, 56 insertions(+), 58 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt b/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt
> deleted file mode 100644
> index 4e8cd7eb7cec..000000000000
> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt
> +++ /dev/null
> @@ -1,58 +0,0 @@
> -* Amlogic HDMI Tx control glue
> -

> +
> +title: Amlogic G12a HDMI TX Control Glue
> +
> +maintainers:
> +  - Jerome Brunet <jbrunet@...libre.com>
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  $nodename:
> +    pattern: "^audio-controller@.*"
> +
> +  "#sound-dai-cells":
> +    const: 1
> +
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: amlogic,g12a-tohdmitx
> +      - items:
> +          - enum:
> +              - amlogic,sm1-tohdmitx
> +          - const: amlogic,g12a-tohdmitx
> +
> +  reg:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  sound-name-prefix: true

Drop

> +
> +required:
> +  - "#sound-dai-cells"
> +  - compatible
> +  - reg
> +  - resets

Please keep the same order as in "properties:" block.

> +
> +additionalProperties: false

and here instead:
unevaluatedProperties: false

> 


Best regards,
Krzysztof