linux-kernel - Re: [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c518f6dd6cf9e92469d37a7317a6881ebed6a8c1.camel@redhat.com>
Date: Thu, 06 Jun 2024 12:32:03 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Diogo Ivo <diogo.ivo@...mens.com>, MD Danish Anwar <danishanwar@...com>,
  Roger Quadros <rogerq@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,  Jakub Kicinski
 <kuba@...nel.org>, Richard Cochran <richardcochran@...il.com>, Nishanth
 Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo
 <kristo@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Jan Kiszka
 <jan.kiszka@...mens.com>, Jacob Keller <jacob.e.keller@...el.com>, Simon
 Horman <horms@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events

On Tue, 2024-06-04 at 14:15 +0100, Diogo Ivo wrote:
> @@ -571,6 +573,57 @@ static int icss_iep_perout_enable(struct icss_iep *iep,
>  	return ret;
>  }
>  
> +static void icss_iep_cap_cmp_work(struct work_struct *work)
> +{
> +	struct icss_iep *iep = container_of(work, struct icss_iep, work);
> +	const u32 *reg_offs = iep->plat_data->reg_offs;
> +	struct ptp_clock_event pevent;
> +	unsigned int val;
> +	u64 ns, ns_next;
> +
> +	spin_lock(&iep->irq_lock);

'irq_lock' is always acquired with the irqsave variant, and here we are
in process context. This discrepancy would at least deserve a comment;
likely the above lock type is not correct.

Cheers,

Paolo