linux-kernel - Re: [PATCH] usb: chipidea: move ci_ulpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0dceea1-3cf1-433d-954b-879f6390c5a4@leemhuis.info>
Date: Thu, 6 Jun 2024 16:03:49 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Alexandre Messier <alex@...ssier.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Michael Grzeschik <m.grzeschik@...gutronix.de>,
 Peter Chen <peter.chen@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 regressions@...ts.linux.dev, wouter@...nken-peeters.be
Subject: Re: [PATCH] usb: chipidea: move ci_ulpi_init after the phy
 initialization

On 30.05.24 08:38, Alexandre Messier wrote:
> On 2024-04-25 15:40, Marek Szyprowski wrote:
>> On 02.04.2024 08:23, Michael Grzeschik wrote:
>>> The function ci_usb_phy_init is already handling the
>>> hw_phymode_configure path which is also only possible after we have
>>> a valid phy. So we move the ci_ulpi_init after the phy initialization
>>> to be really sure to be able to communicate with the ulpi phy.
>>>
>>> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
>>
>> This patch landed in linux-next some time ago as commit 22ffd399e6e7 
>> ("usb: chipidea: move ci_ulpi_init after the phy initialization"). 
>> Unfortunately it breaks host USB operation on DragonBoard410c 
>> (arch/arm64/boot/dts/qcom/apq8016-sbc.dts). There is no error nor 
>> warning in the kernel log besides the information about deferred probe 
>> on the chipidea controller:
> 
> I am also seeing this issue on a msm8974-based device.
> 
> There is also a report and analysis by Wouter Franken here:
> https://lore.kernel.org/all/ecb8d3e8-d525-4a2d-a868-803202c16296@franken-peeters.be/

TWIMC, as this is easy to miss (I was extremely close to writing a
status inquiry instead of writing what I'm typing now): Greg applied
that revert two days ago and I assume he'll soon send it to Linus.

Ciao, Thorsten

#regzbot fix: 718d4a63c0a62d16af1d0425d515d7e76f35681e
#regzbot ignore-activity