linux-kernel - Re: [RFC PATCH 2/5] mm/mmap: Split do_vmi_align_munmap() into a gather and complete operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cpufg5nonojewqgjjjzyyxhkrxxenwe2vvtakvcbe5oleym35j@yzwccr6qim7q>
Date: Fri, 7 Jun 2024 10:23:35 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Vlastimil Babka <vbabka@...e.cz>, sidhartha.kumar@...cle.com,
        Matthew Wilcox <willy@...radead.org>,
        Lorenzo Stoakes <lstoakes@...il.com>, linux-fsdevel@...r.kernel.org,
        bpf@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/5] mm/mmap: Split do_vmi_align_munmap() into a
 gather and complete operation

* Suren Baghdasaryan <surenb@...gle.com> [240606 20:14]:
> On Fri, May 31, 2024 at 9:33 AM Liam R. Howlett <Liam.Howlett@...cle.com> wrote:
> >
> > Split the munmap function into a gathering of vmas and a cleanup of the
> > gathered vmas.  This is necessary for the later patches in the series.
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> 
> The refactoring looks correct but it's quite painful to verify all the
> pieces. Not sure if it could have been refactored in more gradual
> steps...

Okay, I'll see if I can make this into smaller patches that still work.

> 
> Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>
> 
> > ---
> >  mm/mmap.c | 143 ++++++++++++++++++++++++++++++++++++++----------------
> >  1 file changed, 101 insertions(+), 42 deletions(-)
> >
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index 31d464e6a656..fad40d604c64 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -2340,6 +2340,7 @@ static inline void remove_mt(struct mm_struct *mm, struct ma_state *mas)
> >
> >                 if (vma->vm_flags & VM_ACCOUNT)
> >                         nr_accounted += nrpages;
> > +
> 
> nit: here and below a couple of unnecessary empty lines.

Thanks.  I'll remove them in the next revision.