[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7cc32596-8af0-43ff-91fd-59264d0a29ac@linaro.org>
Date: Fri, 7 Jun 2024 16:36:55 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
Joy Chakraborty <joychakr@...gle.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Bingbu Cao <bingbu.cao@...el.com>, Zhihao Cheng <chengzhihao1@...wei.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-iio@...r.kernel.org, linux-media@...r.kernel.org,
linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-mtd@...ts.infradead.org, linux-rtc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
linux-usb@...r.kernel.org, manugautam@...gle.com
Subject: Re: [PATCH v1 07/17] misc: eeprom: at25: Change nvmem reg_read/write
return type
On 06/06/2024 09:41, Dan Carpenter wrote:
> So the original bug was that rmem_read() is returning positive values
> on success instead of zero[1]. That started a discussion about partial
> reads which resulted in changing the API to support partial reads[2].
> That patchset broke the build. This patchset is trying to fix the
> build breakage.
>
> [1]https://lore.kernel.org/all/20240206042408.224138-1-joychakr@google.com/
> [2]https://lore.kernel.org/all/20240510082929.3792559-2-joychakr@google.com/
>
> The bug in rmem_read() is still not fixed. That needs to be fixed as
> a stand alone patch. We can discuss re-writing the API separately.
I agree with Dan, Lets fix the rmem_read and start working on the API
rework in parallel.
Am happy to pick the [1].
--srini
Powered by blists - more mailing lists