linux-kernel - Re: [PATCH] powercap: idle_inject: Simplify if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 7 Jun 2024 20:58:18 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: rafael@...nel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powercap: idle_inject: Simplify if condition

On Wed, Jun 5, 2024 at 3:59 PM Thorsten Blum <thorsten.blum@...lux.com> wrote:
>
> The if condition !A || A && B can be simplified to !A || B.
>
> Fixes the following Coccinelle/coccicheck warning reported by
> excluded_middle.cocci:
>
>         WARNING !A || A && B is equivalent to !A || B
>
> Compile-tested only.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  drivers/powercap/idle_inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
> index e18a2cc4e46a..bafc59904ed3 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -127,7 +127,7 @@ static enum hrtimer_restart idle_inject_timer_fn(struct hrtimer *timer)
>         struct idle_inject_device *ii_dev =
>                 container_of(timer, struct idle_inject_device, timer);
>
> -       if (!ii_dev->update || (ii_dev->update && ii_dev->update()))
> +       if (!ii_dev->update || ii_dev->update())
>                 idle_inject_wakeup(ii_dev);
>
>         duration_us = READ_ONCE(ii_dev->run_duration_us);
> --

Applied as 6.11 material, thanks!