linux-kernel - Re: [PATCH v5 08/12] net: stmmac: dwmac-stm32: add management of stm32mp13 for stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <329fb476-405e-458e-98a8-883ecd9cf15a@denx.de>
Date: Fri, 7 Jun 2024 21:54:16 +0200
From: Marek Vasut <marex@...x.de>
To: Christophe ROULLIER <christophe.roullier@...s.st.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Richard Cochran <richardcochran@...il.com>, Jose Abreu
 <joabreu@...opsys.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 08/12] net: stmmac: dwmac-stm32: add management of
 stm32mp13 for stm32

On 6/7/24 2:59 PM, Christophe ROULLIER wrote:
> 
> On 6/7/24 14:48, Marek Vasut wrote:
>> On 6/7/24 11:57 AM, Christophe Roullier wrote:
>>
>> [...]
>>
>>> @@ -224,11 +225,18 @@ static int stm32mp1_configure_pmcr(struct 
>>> plat_stmmacenet_data *plat_dat)
>>>   {
>>>       struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
>>>       u32 reg = dwmac->mode_reg;
>>> -    int val;
>>> +    int val = 0;
>>
>> Is the initialization really needed ? It seems the switch-case below 
>> does always initialize $val .
> 
> Yes it is needed otherwise:
> 
>>> drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:239:4: warning: 
>>> variable 'val' is uninitialized when used here [-Wuninitialized]
> 
> val |= SYSCFG_PMCR_ETH_SEL_MII;
>                             ^~~
>     drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:228:9: note: 
> initialize the variable 'val' to silence this warning
>             int val;

OK, thanks for checking.