linux-kernel - Re: [PATCH RESEND] mcb: mcb-pci: detect IO mapped devices before requesting resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmNwvsngNZhEGNfv@surfacebook.localdomain>
Date: Fri, 7 Jun 2024 23:42:38 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Sanjuán García, Jorge <Jorge.SanjuanGarcia@...gon.com>
Cc: "morbidrsa@...il.com" <morbidrsa@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jth@...nel.org" <jth@...nel.org>,
	Rodríguez Barbarin, José Javier <josejavier.rodriguez@...gon.com>
Subject: Re: [PATCH RESEND] mcb: mcb-pci: detect IO mapped devices before
 requesting resources

Thu, May 23, 2024 at 10:35:03AM +0000, Sanjuán García, Jorge kirjoitti:
> If the memory region is requested with devm_request_mem_region()
> for an IO mapped device it will return an error and mcb-pci will
> incorrectly report it with EBUSY code.
> 
> Make sure we identify if the reosure is IO mapped and fail early
> with a correct ENOTSUPP code.

No, ENOTSUPP is incorrect code in this case. Have you run checkpatch?
Please, submit a patch to change this error code to one from the POSIX range.

-- 
With Best Regards,
Andy Shevchenko