linux-kernel - Re: [PATCH v4] selftest: mm: Test if hugepage does not get leaked during __bio_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240607205247.b7touyyblwcpamfm@quentin>
Date: Fri, 7 Jun 2024 20:52:47 +0000
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Donet Tom <donettom@...ux.ibm.com>, Shuah Khan <shuah@...nel.org>,
	Matthew Wilcox <willy@...radead.org>,
	Tony Battersby <tonyb@...ernetics.com>, linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ritesh Harjani <ritesh.list@...il.com>,
	Mike Rapoport <rppt@...nel.org>,
	Muchun Song <songmuchun@...edance.com>,
	David Hildenbrand <david@...hat.com>, p.raghav@...sung.com,
	usama.anjum@...labora.com
Subject: Re: [PATCH v4] selftest: mm: Test if hugepage does not get leaked
 during __bio_release_pages()

On Fri, Jun 07, 2024 at 01:06:23PM -0700, Andrew Morton wrote:
> On Fri,  7 Jun 2024 13:20:00 -0500 Donet Tom <donettom@...ux.ibm.com> wrote:
> 
> > V4:
> > - Added this test to run_vmtests.sh.
> 
> v4 also contains this change:

I think v3 already had these changes [1]

V3:
- Fixed the build error when it is compiled with _FORTIFY_SOURCE.

[1] https://lore.kernel.org/linux-kselftest/20240607055046.138650-1-donettom@linux.ibm.com/
> 
> --- a/tools/testing/selftests/mm/hugetlb_dio.c~selftest-mm-test-if-hugepage-does-not-get-leaked-during-__bio_release_pages-v4
> +++ a/tools/testing/selftests/mm/hugetlb_dio.c
> @@ -40,7 +40,7 @@ void run_dio_using_hugetlb(unsigned int
>  		ksft_exit_fail_msg("Unable to determine huge page size\n");
>  
>  	/* Open the file to DIO */
> -	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT);
> +	fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664);
>  	if (fd < 0)
>  		ksft_exit_fail_perror("Error opening file\n");
>  
>