linux-kernel - Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b16316c9-67b8-4afa-af5c-6d3fb33c3c6f@linuxfoundation.org>
Date: Fri, 7 Jun 2024 15:55:46 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Okan Tümüklü <okantumukluu@...il.com>,
 brauner@...nel.org
Cc: shuah@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Mickaël Salaün
 <mic@...ikod.net>, Kees Cook <keescook@...omium.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation

On 6/6/24 12:02, Okan Tümüklü wrote:
> From: Mickaël Salaün <mic@...ikod.net>
> 
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
> 
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Reviewed-by: Christian Brauner <brauner@...nel.org>
> Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <mic@...ikod.net>
Date:   Sat May 11 19:14:42 2024 +0200

     selftests/pidfd: Fix wrong expectation
     
     Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
     which will be actually tested on the parent and child sides with a
     following commit.
     
     Cc: Shuah Khan <skhan@...uxfoundation.org>
     Reviewed-by: Kees Cook <keescook@...omium.org>
     Reviewed-by: Christian Brauner <brauner@...nel.org>
     Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
     Signed-off-by: Mickaël Salaün <mic@...ikod.net>


thanks,
-- Shuah