linux-kernel - Re: [PATCH] watchdog: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13501da7-3e65-4401-9e21-eb3a1f93f4a8@roeck-us.net>
Date: Fri, 7 Jun 2024 15:15:54 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
 Johannes Thumshirn <jth@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Gerd Haeussler <gerd.haeussler.ext@...mens.com>,
 Xing Tong Wu <xingtong.wu@...mens.com>,
 Tobias Schaffner <tobias.schaffner@...mens.com>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] watchdog: add missing MODULE_DESCRIPTION() macros

On 6/7/24 11:04, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/watchdog/omap_wdt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/watchdog/twl4030_wdt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/watchdog/ts4800_wdt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/watchdog/simatic-ipc-wdt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/watchdog/menz69_wdt.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/menz69_wdt.c      | 1 +
>   drivers/watchdog/omap_wdt.c        | 1 +
>   drivers/watchdog/simatic-ipc-wdt.c | 1 +
>   drivers/watchdog/ts4800_wdt.c      | 1 +
>   drivers/watchdog/twl4030_wdt.c     | 1 +
>   5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
> index c7de30270043..0508a65acfa6 100644
> --- a/drivers/watchdog/menz69_wdt.c
> +++ b/drivers/watchdog/menz69_wdt.c
> @@ -161,6 +161,7 @@ static struct mcb_driver men_z069_driver = {
>   module_mcb_driver(men_z069_driver);
>   
>   MODULE_AUTHOR("Johannes Thumshirn <jth@...nel.org>");
> +MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
>   MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("mcb:16z069");
>   MODULE_IMPORT_NS(MCB);
> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
> index a7a12f2fe9de..b6e0236509bb 100644
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -370,5 +370,6 @@ static struct platform_driver omap_wdt_driver = {
>   module_platform_driver(omap_wdt_driver);
>   
>   MODULE_AUTHOR("George G. Davis");
> +MODULE_DESCRIPTION("Driver for the TI OMAP 16xx/24xx/34xx 32KHz (non-secure) watchdog");
>   MODULE_LICENSE("GPL");
>   MODULE_ALIAS("platform:omap_wdt");
> diff --git a/drivers/watchdog/simatic-ipc-wdt.c b/drivers/watchdog/simatic-ipc-wdt.c
> index cdc1a2e15180..1e91f0a560ff 100644
> --- a/drivers/watchdog/simatic-ipc-wdt.c
> +++ b/drivers/watchdog/simatic-ipc-wdt.c
> @@ -227,6 +227,7 @@ static struct platform_driver simatic_ipc_wdt_driver = {
>   
>   module_platform_driver(simatic_ipc_wdt_driver);
>   
> +MODULE_DESCRIPTION("Siemens SIMATIC IPC driver for Watchdogs");
>   MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:" KBUILD_MODNAME);
>   MODULE_AUTHOR("Gerd Haeussler <gerd.haeussler.ext@...mens.com>");
> diff --git a/drivers/watchdog/ts4800_wdt.c b/drivers/watchdog/ts4800_wdt.c
> index 0099403f4992..24b1ad52102e 100644
> --- a/drivers/watchdog/ts4800_wdt.c
> +++ b/drivers/watchdog/ts4800_wdt.c
> @@ -200,5 +200,6 @@ static struct platform_driver ts4800_wdt_driver = {
>   module_platform_driver(ts4800_wdt_driver);
>   
>   MODULE_AUTHOR("Damien Riegel <damien.riegel@...oirfairelinux.com>");
> +MODULE_DESCRIPTION("Watchdog driver for TS-4800 based boards");
>   MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:ts4800_wdt");
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 09d17e20f4a7..8c80d04811e4 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -118,6 +118,7 @@ static struct platform_driver twl4030_wdt_driver = {
>   module_platform_driver(twl4030_wdt_driver);
>   
>   MODULE_AUTHOR("Nokia Corporation");
> +MODULE_DESCRIPTION("TWL4030 Watchdog");
>   MODULE_LICENSE("GPL");
>   MODULE_ALIAS("platform:twl4030_wdt");
>   
> 
> ---
> base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
> change-id: 20240607-md-drivers-watchdog-79132a7cc0b0
> 
>