linux-kernel - Re: [PATCH] block: fix request.queuelist usage in flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240607045511.GB2857@lst.de>
Date: Fri, 7 Jun 2024 06:55:11 +0200
From: Christoph Hellwig <hch@....de>
To: Chengming Zhou <chengming.zhou@...ux.dev>
Cc: Friedrich Weber <f.weber@...xmox.com>, axboe@...nel.dk,
	ming.lei@...hat.com, hch@....de, bvanassche@....org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	zhouchengming@...edance.com,
	Thomas Lamprecht <t.lamprecht@...xmox.com>
Subject: Re: [PATCH] block: fix request.queuelist usage in flush

On Fri, Jun 07, 2024 at 10:37:58AM +0800, Chengming Zhou wrote:
> Yeah, right, it seems LVM may create this special request that only has
> PREFLUSH | POSTFLUSH without any DATA, goes into the flush state machine.
> Then, cause the request double list_add_tail() without list_del_init().
> I don't know the reason behind it, but well, it's allowable in the current
> flush code.

PREFLUSH | POSTFLUSH is a weird invalid format.  We'll need to fix this
in dm, and probably also catch it in the block layer submission path.