linux-kernel - Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe0ec57b-dad3-4666-abe3-75bcb65fa7df@norik.com>
Date: Fri, 7 Jun 2024 08:14:40 +0200
From: Primoz Fiser <primoz.fiser@...ik.com>
To: Mark Brown <broonie@...nel.org>, Péter Ujfalusi
 <peter.ujfalusi@...il.com>
Cc: Jarkko Nikula <jarkko.nikula@...mer.com>,
 Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
 linux-omap@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, upstream@...ts.phytec.de
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Hi,

On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
> 
>>> -	card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> -				    "HDMI %s", dev_name(ad->dssdev));
>>> -	if (!card->name)
>>> -		return -ENOMEM;
>>> -
>>> +	card->name = DRV_NAME;
> 
>> I think it would be better to name is simply "HDMI" instead
> 
> That does seem a bit more user friendly.

So card->name = "HDMI" for v2?

Thanks,
BR,
Primoz

-- 
Primoz Fiser                    | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o.            | https://www.norik.com
<https://www.norik.com>  |
Your embedded software partner  | email: info@...ik.com
<mailto:info@...ik.com> |
Slovenia, EU                    | phone: +386-41-540-545
<tel:+386-41-540-545> |