linux-kernel - Re: [PATCH 3/5] arm64: dts: qcom: sdx75: add missing qlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da06a758-5239-42d6-e4f8-c78418d9529d@quicinc.com>
Date: Fri, 7 Jun 2024 12:21:06 +0530
From: Naina Mehta <quic_nainmeht@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <andersson@...nel.org>,
        <mathieu.poirier@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <konrad.dybcio@...aro.org>,
        <manivannan.sadhasivam@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging
 reserved memory for mpss

On 6/6/2024 8:20 PM, Krzysztof Kozlowski wrote:
> On 06/06/2024 16:38, Naina Mehta wrote:
>> The qlink_logging memory region is also used by the modem firmware,
>> add it to reserved memory regions.
>> Also split MPSS DSM region into 2 separate regions.
>>
>> Signed-off-by: Naina Mehta <quic_nainmeht@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
>>   1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> index 9b93f6501d55..9349b1c4e196 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> @@ -366,7 +366,12 @@
>>   			no-map;
>>   		};
>>   
>> -		qdss_mem: qdss@...00000 {
>> +		qdss_mem: qdss@...00000 {
>> +			reg = <0x0 0x88500000 0x0 0x300000>;
>> +			no-map;
>> +		};
>> +
>> +		qlink_logging_mem: qlink_logging@...00000 {
> 
> Sorry, no downstream code.
> 
> Please follow DTS coding style - no underscores in node names. This
> applies to all work sent upstream.
> 

Thanks for pointing this out. I will update in next revision.

Regards,
Naina

> 
> 
> Best regards,
> Krzysztof
>