[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c5199da0d4542c7ab8eec1c6d36fc329a937019a.camel@codeconstruct.com.au>
Date: Fri, 07 Jun 2024 15:28:17 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Aniket <aniketmaurya@...gle.com>, Alexandre Belloni
<alexandre.belloni@...tlin.com>, Joel Stanley <joel@....id.au>, Billy Tsai
<billy_tsai@...eedtech.com>
Cc: linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i3c: dw: Fix IBI intr programming
Hi Aniket,
> IBI_SIR_REQ_REJECT register is not present if the IP has
> IC_HAS_IBI_DATA = 1 set. So don't rely on doing read-
> modify-write op on this register.
> Instead maintain a variable to store the sir reject mask
> and use it to set IBI_SIR_REQ_REJECT.
Looks good, thanks!
Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>
Cheers,
Jeremy
Powered by blists - more mailing lists