linux-kernel - Re: [PATCH 0/8] iio: simplify with spi_get_device_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 07 Jun 2024 10:55:44 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Lucas Stankus
 <lucas.p.stankus@...il.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron
 <jic23@...nel.org>, Puranjay Mohan <puranjay@...nel.org>, Ramona Bolboaca
 <ramona.bolboaca@...log.com>, Oleksij Rempel <o.rempel@...gutronix.de>,
 kernel@...gutronix.de, Cosmin Tanislav <cosmin.tanislav@...log.com>, Marius
 Cristea <marius.cristea@...rochip.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] iio: simplify with spi_get_device_match_data()

On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote:
> Not tested on hardware, but code looks equivalent and should not have
> functional effect.
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (8):
>       iio: accel: adxl313: simplify with spi_get_device_match_data()
>       iio: accel: adxl355: simplify with spi_get_device_match_data()
>       iio: adc: max11205: simplify with spi_get_device_match_data()
>       iio: adc: ti-ads131e08: simplify with spi_get_device_match_data()
>       iio: adc: ti-tsc2046: simplify with spi_get_device_match_data()
>       iio: addac: ad74413r: simplify with spi_get_device_match_data()
>       iio: dac: max5522: simplify with spi_get_device_match_data()
>       iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data()
> 
>  drivers/iio/accel/adxl313_spi.c |  8 +-------
>  drivers/iio/accel/adxl355_spi.c | 10 +++-------
>  drivers/iio/adc/max11205.c      |  5 +----
>  drivers/iio/adc/mcp3564.c       |  6 ------
>  drivers/iio/adc/ti-ads131e08.c  |  4 +---
>  drivers/iio/adc/ti-tsc2046.c    |  7 +------
>  drivers/iio/addac/ad74413r.c    | 13 +++----------
>  drivers/iio/dac/max5522.c       | 11 +++--------
>  8 files changed, 13 insertions(+), 51 deletions(-)
> ---

LGTM, just some minor comments/asks that don't really stop me from:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>