linux-kernel - Re: [PATCH v4 0/3] ACPI: PMIC: a small refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <179d5111-5cc8-4a17-b735-84f02e0144f5@redhat.com>
Date: Fri, 7 Jun 2024 11:05:51 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v4 0/3] ACPI: PMIC: a small refactoring

Hi,

On 6/6/24 10:54 PM, Andy Shevchenko wrote:
> Use sizeof(), dev_err()/dev_warn(), and regmap bulk read
> where it makes sense.
> 
> In v4:
> - dropped controversial changes (Hans)

Thanks, the whole series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

for the series.

Regards,

Hans

> 
> Andy Shevchenko (3):
>   ACPI: PMIC: Use sizeof() instead of hard coded value
>   ACPI: PMIC: Convert pr_*() to dev_*() printing macros
>   ACPI: PMIC: Replace open coded be16_to_cpu()
> 
>  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 13 ++++++++-----
>  drivers/acpi/pmic/intel_pmic_chtwc.c    |  5 +++--
>  drivers/acpi/pmic/intel_pmic_xpower.c   |  7 ++++---
>  3 files changed, 15 insertions(+), 10 deletions(-)
>