linux-kernel - Re: [PATCH v6 5/9] iio: adc: ad7173: refactor ain and vref selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f230e9a-31bb-45e1-ab86-b80b30ad8502@gmail.com>
Date: Fri, 7 Jun 2024 12:37:48 +0300
From: "Ceclan, Dumitru" <mitrutzceclan@...il.com>
To: Nuno Sá <noname.nuno@...il.com>,
 dumitru.ceclan@...log.com
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, David Lechner <dlechner@...libre.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/9] iio: adc: ad7173: refactor ain and vref selection

On 07/06/2024 12:04, Nuno Sá wrote:
> On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
>> From: Dumitru Ceclan <dumitru.ceclan@...log.com>
>>
>> Move validation of analog inputs and reference voltage selection to
>> separate functions to reduce the size of the channel config parsing
>> function and improve readability.
>> Add defines for the number of analog inputs in a channel.
>>
>> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
>> ---
>>  drivers/iio/adc/ad7173.c | 68 +++++++++++++++++++++++++++++++++--------------
>> -
>>  1 file changed, 47 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
>> index 8631f218b69e..4040edbd1c32 100644
>> --- a/drivers/iio/adc/ad7173.c
>> +++ b/drivers/iio/adc/ad7173.c
>> @@ -60,6 +60,7 @@
>>  #define AD7173_CH_SETUP_AINPOS_MASK	GENMASK(9, 5)
>>  #define AD7173_CH_SETUP_AINNEG_MASK	GENMASK(4, 0)
>>  
>> +#define AD7173_NO_AINS_PER_CHANNEL	2
>>  #define AD7173_CH_ADDRESS(pos, neg) \
>>  	(FIELD_PREP(AD7173_CH_SETUP_AINPOS_MASK, pos) | \
>>  	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
>> @@ -629,6 +630,7 @@ static int ad7173_setup(struct iio_dev *indio_dev)
>>  static unsigned int ad7173_get_ref_voltage_milli(struct ad7173_state *st,
>>  						 u8 reference_select)
>>  {
>> +	struct device *dev = &st->sd.spi->dev;
>>  	int vref;
>>  
>>  	switch (reference_select) {
>> @@ -652,9 +654,11 @@ static unsigned int ad7173_get_ref_voltage_milli(struct
>> ad7173_state *st,
>>  		return -EINVAL;
>>  	}
>>  
>> -	if (vref < 0)
>> +	if (vref < 0) {
>> +		dev_err(dev, "Cannot use reference %u. Error:%d\n",
>> +			reference_select, vref);
>>  		return vref;
>> -
>> +	}
>>  	return vref / (MICRO / MILLI);
>>  }
> 
> unrelated?
> 
> - Nuno Sá
> 

Hmm, maybe I misunderstood "Any error log needed should be done inside ad7173_get_ref_voltage_milli()"
https://lore.kernel.org/all/71452f6882efe6a181d477914488617d28a38e2f.camel@gmail.com/

This change should be in a different patch or should it not've been done
this way?