linux-kernel - Re: [PATCH v4 1/7] kexec_file: allow to place kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <v23pityqahr6tgkhnfjoloqwhxcef23i6xjvpb23qbql5rq436@3baoli7d5vta>
Date: Fri, 7 Jun 2024 20:26:48 +0800
From: Coiby Xu <coxu@...hat.com>
To: Baoquan He <bhe@...hat.com>
Cc: kexec@...ts.infradead.org, Ondrej Kozina <okozina@...hat.com>, 
	Milan Broz <gmazyland@...il.com>, Thomas Staudt <tstaudt@...ibm.com>, 
	Daniel P . Berrangé <berrange@...hat.com>, Kairui Song <ryncsn@...il.com>, 
	Jan Pazdziora <jpazdziora@...hat.com>, Pingfan Liu <kernelfans@...il.com>, 
	Dave Young <dyoung@...hat.com>, linux-kernel@...r.kernel.org, x86@...nel.org, 
	Dave Hansen <dave.hansen@...el.com>, Vitaly Kuznetsov <vkuznets@...hat.com>, 
	Eric Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH v4 1/7] kexec_file: allow to place kexec_buf randomly

On Tue, Jun 04, 2024 at 03:41:35PM +0800, Baoquan He wrote:
>On 05/23/24 at 01:04pm, Coiby Xu wrote:
>> Currently, kexec_buf is placed in order which means for the same
>> machine, the info in the kexec_buf is always located at the same
>> position each time the machine is booted. This may cause a risk for
>> sensitive information like LUKS volume key. Now struct kexec_buf has a
>> new field random which indicates it's supposed to be placed in a random
>> position.
>>
>> Suggested-by: Jan Pazdziora <jpazdziora@...hat.com>
>> Signed-off-by: Coiby Xu <coxu@...hat.com>
>> ---
>>  include/linux/kexec.h |  2 ++
>>  kernel/kexec_file.c   | 15 +++++++++++++++
>>  2 files changed, 17 insertions(+)
>>
>> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
>> index f0e9f8eda7a3..cc81b8a903ab 100644
>> --- a/include/linux/kexec.h
>> +++ b/include/linux/kexec.h
[...]
>> @@ -445,6 +456,8 @@ static int locate_mem_hole_top_down(unsigned long start, unsigned long end,
>>
>>  	temp_end = min(end, kbuf->buf_max);
>>  	temp_start = temp_end - kbuf->memsz + 1;
>> +	if (kbuf->random)
>> +		temp_start = kexec_random_start(temp_start, temp_end);
>
>As we discussed before, this need be limited in kdump scope, seems v4
>doesn't include the change.

Yes, v4 was sent mainly for you to review the patches by applying to
latest Linus tree. v5 now include the change.

-- 
Best regards,
Coiby