linux-kernel - Re: [PATCH v4 5/7] crash_dump: retrieve dm crypt keys in kdump kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fucfvhq74bzdhzowvso7re3c6c3bhtqj5trxe5gl3p7cgzgym@xz7wdxw3wojr>
Date: Fri, 7 Jun 2024 20:27:37 +0800
From: Coiby Xu <coxu@...hat.com>
To: Baoquan He <bhe@...hat.com>
Cc: kexec@...ts.infradead.org, Ondrej Kozina <okozina@...hat.com>, 
	Milan Broz <gmazyland@...il.com>, Thomas Staudt <tstaudt@...ibm.com>, 
	Daniel P . Berrangé <berrange@...hat.com>, Kairui Song <ryncsn@...il.com>, 
	Jan Pazdziora <jpazdziora@...hat.com>, Pingfan Liu <kernelfans@...il.com>, 
	Dave Young <dyoung@...hat.com>, linux-kernel@...r.kernel.org, x86@...nel.org, 
	Dave Hansen <dave.hansen@...el.com>, Vitaly Kuznetsov <vkuznets@...hat.com>, 
	Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH v4 5/7] crash_dump: retrieve dm crypt keys in kdump kernel

On Fri, Jun 07, 2024 at 05:50:15PM +0800, Baoquan He wrote:
>On 05/23/24 at 01:04pm, Coiby Xu wrote:
>......
>> +ssize_t __weak dm_crypt_keys_read(char *buf, size_t count, u64 *ppos)
>> +{
>> +	struct kvec kvec = { .iov_base = buf, .iov_len = count };
>> +	struct iov_iter iter;
>> +
>> +	iov_iter_kvec(&iter, READ, &kvec, 1, count);
>> +	return read_from_oldmem(&iter, count, ppos, false);
>Do we need create a x86 specific version to cope with the confidential
>computing thing, e.g sme/tdx?

Thanks for raising the concern! I'll test sme/tdx and will fix it in v6
if any issue is found.

-- 
Best regards,
Coiby