linux-kernel - Re: [PATCH] platform/x86: dell-pc: avoid double free and invalid unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 07 Jun 2024 16:22:45 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Lyndon Sanche <lsanche@...deno.ca>, Hans de Goede <hdegoede@...hat.com>, 
 Thomas Weißschuh <linux@...ssschuh.net>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-pc: avoid double free and invalid
 unregistration

On Tue, 04 Jun 2024 23:41:24 +0200, Thomas Weißschuh wrote:

> If platform_profile_register() fails it does kfree(thermal_handler) and
> leaves the pointer value around.
> Any call to thermal_cleanup() will try to kfree(thermal_handler) again.
> This will happen right away in dell_init().
> In addition, platform_profile_remove() will be called although no
> profile is registered.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-pc: avoid double free and invalid unregistration
      commit: dd637f5cd5f334d2d014872544470031415cec3b

--
 i.