linux-kernel - Re: [PATCH] iio: event: use sizeof(*pointer) instead of sizeof(type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 8 Jun 2024 15:16:43 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Erick Archer <erick.archer@...look.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Kees Cook <keescook@...omium.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, Justin Stitt
 <justinstitt@...gle.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] iio: event: use sizeof(*pointer) instead of
 sizeof(type)

On Sun,  2 Jun 2024 19:23:54 +0200
Erick Archer <erick.archer@...look.com> wrote:

> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter). At the same time refactor
> the NULL comparison.
> 
> This patch has no effect on runtime behavior.
> 
> Signed-off-by: Erick Archer <erick.archer@...look.com>

Applied.
> ---
>  drivers/iio/industrialio-event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index 910c1f14abd5..b99bfeff7d37 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -572,8 +572,8 @@ int iio_device_register_eventset(struct iio_dev *indio_dev)
>  	      iio_check_for_dynamic_events(indio_dev)))
>  		return 0;
>  
> -	ev_int = kzalloc(sizeof(struct iio_event_interface), GFP_KERNEL);
> -	if (ev_int == NULL)
> +	ev_int = kzalloc(sizeof(*ev_int), GFP_KERNEL);
> +	if (!ev_int)
>  		return -ENOMEM;
>  
>  	iio_dev_opaque->event_interface = ev_int;