linux-kernel - Re: [PATCH] iio: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 8 Jun 2024 17:38:51 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Paul Cercueil <paul@...pouillou.net>, Lars-Peter Clausen
 <lars@...afoo.de>, Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>,
 Michal Simek <michal.simek@....com>, <linux-mips@...r.kernel.org>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] iio: add missing MODULE_DESCRIPTION() macros

On Fri, 7 Jun 2024 09:17:52 -0700
Jeff Johnson <quic_jjohnson@...cinc.com> wrote:

> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/iio/adc/ingenic-adc.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/iio/adc/xilinx-ams.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/iio/buffer/kfifo_buf.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
Hi Jeff,

Thanks for tidying these up.

Applied to the togreg branch of iio.git and pushed out as testing
because there is other stuff I need 0-day to take a look at.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ingenic-adc.c  | 1 +
>  drivers/iio/adc/xilinx-ams.c   | 1 +
>  drivers/iio/buffer/kfifo_buf.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
> index a7325dbbb99a..af70ca760797 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -920,4 +920,5 @@ static struct platform_driver ingenic_adc_driver = {
>  	.probe = ingenic_adc_probe,
>  };
>  module_platform_driver(ingenic_adc_driver);
> +MODULE_DESCRIPTION("ADC driver for the Ingenic JZ47xx SoCs");
>  MODULE_LICENSE("GPL v2");
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index f0b71a1220e0..ee45475c495b 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -1430,5 +1430,6 @@ static struct platform_driver ams_driver = {
>  };
>  module_platform_driver(ams_driver);
>  
> +MODULE_DESCRIPTION("Xilinx AMS driver");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Xilinx, Inc.");
> diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_buf.c
> index 05b285f0eb22..38034c8bcc04 100644
> --- a/drivers/iio/buffer/kfifo_buf.c
> +++ b/drivers/iio/buffer/kfifo_buf.c
> @@ -287,4 +287,5 @@ int devm_iio_kfifo_buffer_setup_ext(struct device *dev,
>  }
>  EXPORT_SYMBOL_GPL(devm_iio_kfifo_buffer_setup_ext);
>  
> +MODULE_DESCRIPTION("Industrial I/O buffering based on kfifo");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
> change-id: 20240607-md-drivers-iic-cab420a99216
>