linux-kernel - Re: [PATCH v4 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202406081148.j9y5W5Ru-lkp@intel.com>
Date: Sat, 8 Jun 2024 11:19:10 +0800
From: kernel test robot <lkp@...el.com>
To: Yasin Lee <yasin.lee.x@...look.com>, jic23@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	andy.shevchenko@...il.com, lars@...afoo.de,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	nuno.a@...log.com, swboyd@...omium.org,
	u.kleine-koenig@...gutronix.de, yasin.lee.x@...il.com,
	yasin.lee.x@...look.com
Subject: Re: [PATCH v4 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor
 driver

Hi Yasin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.10-rc2 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yasin-Lee/iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver/20240607-194446
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/SN7PR12MB81017291E79E6B61A8DEC9A5A4FB2%40SN7PR12MB8101.namprd12.prod.outlook.com
patch subject: [PATCH v4 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240608/202406081148.j9y5W5Ru-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240608/202406081148.j9y5W5Ru-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406081148.j9y5W5Ru-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/proximity/hx9023s.c:666:58: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
     666 |                                         "Failed to read channel-positive for channel %d\n", i);
         |                                                                                             ^
   drivers/iio/proximity/hx9023s.c:652:12: note: initialize the variable 'i' to silence this warning
     652 |         int ret, i;
         |                   ^
         |                    = 0
   drivers/iio/proximity/hx9023s.c:976:25: warning: variable 'i' is uninitialized when used here [-Wuninitialized]
     976 |                 data->buffer.channels[i++] =
         |                                       ^
   drivers/iio/proximity/hx9023s.c:969:7: note: initialize the variable 'i' to silence this warning
     969 |         int i;
         |              ^
         |               = 0
   2 warnings generated.


vim +/i +666 drivers/iio/proximity/hx9023s.c

   649	
   650	static int hx9023s_property_get(struct hx9023s_data *data)
   651	{
   652		int ret, i;
   653		u32 temp;
   654		struct fwnode_handle *child;
   655		struct device *dev = regmap_get_device(data->regmap);
   656	
   657		ret = device_property_read_u32(dev, "channel-in-use", &temp);
   658		if (ret)
   659			return dev_err_probe(dev, ret, "Failed to read channel-in-use property\n");
   660		data->chan_in_use = temp;
   661	
   662		device_for_each_child_node(dev, child) {
   663			ret = fwnode_property_read_u32(child, "channel-positive", &temp);
   664			if (ret)
   665				return dev_err_probe(dev, ret,
 > 666						"Failed to read channel-positive for channel %d\n", i);
   667			data->ch_data[i].channel_positive = temp;
   668	
   669			ret = fwnode_property_read_u32(child, "channel-negative", &temp);
   670			if (ret)
   671				return dev_err_probe(dev, ret,
   672						"Failed to read channel-negative for channel %d\n", i);
   673			data->ch_data[i].channel_negative = temp;
   674	
   675			i++;
   676		}
   677	
   678		return 0;
   679	}
   680	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki