linux-kernel - Re: [PATCH V3 1/3] platform/x86/intel/sdsi: Add ioctl SPDM transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b23fadac815f137ad93fa3bb90149e52956b3c62.camel@linux.intel.com>
Date: Fri, 07 Jun 2024 20:44:47 -0700
From: "David E. Box" <david.e.box@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: linux-doc@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>, LKML
	 <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH V3 1/3] platform/x86/intel/sdsi: Add ioctl SPDM transport

On Fri, 2024-06-07 at 16:14 +0300, Ilpo Järvinen wrote:
> On Wed, 5 Jun 2024, David E. Box wrote:
> 
> > Intel On Demand adds attestation and firmware measurement retrieval
> > services through use of the protocols defined the Security Protocols and
> > Data Measurement (SPDM) specification. SPDM messages exchanges are used to
> > authenticate On Demand hardware and to retrieve signed measurements of the
> > NVRAM state used to track feature provisioning and the NVRAM state used for
> > metering services. These allow software to verify the authenticity of the
> > On Demand hardware as well as the integrity of the reported silicon
> > configuration.
> > 
> > Add an ioctl interface for sending SPDM messages through the On Demand
> > mailbox. Provides commands to get a list of SPDM enabled devices, get the
> > message size limits for SPDM Requesters and Responders, and perform an SPDM
> > message exchange.
> > 
> > Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> > Link:
> > https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.0.1.pdf
> >  [1]
> > ---
> 
> > +static int sdsi_spdm_do_command(struct sdsi_priv *priv,
> > +                               struct sdsi_spdm_command __user *argp)
> > +{
> > +       u32 req_size, rsp_size;
> > +
> > +       if (get_user(req_size, &argp->size))
> > +               return -EFAULT;
> > +
> > +       if (req_size < 4 || req_size > sizeof(struct sdsi_spdm_message))
> 
> Hi David,
> 
> Is that 4 actually SPDM_HEADER_SIZE?
> 
> If my guess is correct, no need to send an updated version, I'll just fix 
> it while applying.

It is SPDM_HEADER_SIZE but I already fixed it in V4 since I had to address an
LKP report.

David

> 
>