linux-kernel - Re: [PATCH] igb: Add support for firmware update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9903f5cb-f4e6-42f1-a8b1-b3b5da593dc7@web.de>
Date: Sun, 9 Jun 2024 15:22:52 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Richard chien <richard.chien@....com>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: Richard chien <m8809301@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH] igb: Add support for firmware update

> This patch adds support for firmware update to the in-tree igb driver and it is actually a port from the out-of-tree igb driver.
> In-band firmware update is one of the essential system maintenance tasks. To simplify this task, the Intel online firmware update
…

Please improve such a change description also according to word wrapping
because of more desirable text line lengths.

…
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -724,128 +724,282 @@ static void igb_get_regs(struct net_device *netdev,
>  		regs_buff[739] = rd32(E1000_I210_RR2DCDELAY);
>  }
>
> -static int igb_get_eeprom_len(struct net_device *netdev)
> -{
> -	struct igb_adapter *adapter = netdev_priv(netdev);
> -	return adapter->hw.nvm.word_size * 2;
> +static u8 igb_nvmupd_get_module(u32 val)
> +{
> +        return (u8)(val & E1000_NVMUPD_MOD_PNT_MASK);
> +}
…

Would you like to reconsider the indentation once more for your change approach?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10-rc2#n18

Regards,
Markus