linux-kernel - Re: [PATCH 1/5] kunit: string-stream: export non-static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <655c6a80-53d0-4a9c-b242-25936646e49c@gmail.com>
Date: Sun, 9 Jun 2024 20:01:26 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: David Gow <davidgow@...gle.com>
Cc: brendan.higgins@...ux.dev, rmoar@...gle.com,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] kunit: string-stream: export non-static functions

On 6/8/24 10:20, David Gow wrote:
> On Tue, 4 Jun 2024 at 20:32, Ivan Orlov <ivan.orlov0322@...il.com> wrote:
>>
>> Export non-static functions from the string-stream.c file into the KUnit
>> namespace in order to be able to access them from the KUnit core tests
>> (when they are loaded as modules).
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
>> ---
> 
> Looks good to me, thanks.
> 
> It's very slightly hilarious to use EXPORT_SYMBOL_IF_KUNIT() here,
> because _of course_ KUnit is enabled, but I think it's the right idea
> nevertheless.
> 
> Reviewed-by: David Gow <davidgow@...gle.com>

Hi David,

Thank you for the review.

Yes, the name of the EXPORT_SYMBOL_IF_KUNIT macro in this case is a bit 
confusing... It is used not only to export the symbol conditionally (if 
CONFIG_KUNIT is enabled), but also to export the symbol into the KUnit 
namespace (so I used it as a shortcut for this action here) :)

-- 
Kind regards,
Ivan Orlov