linux-kernel - Re: [PATCH 07/14] net: bridge: replace call_rcu by kfree_rcu for simple kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2d17c74-86fd-4436-9156-271045ab1a45@blackwall.org>
Date: Sun, 9 Jun 2024 12:04:53 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Julia Lawall <Julia.Lawall@...ia.fr>, Roopa Prabhu <roopa@...dia.com>
Cc: kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, bridge@...ts.linux.dev,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Paul E . McKenney" <paulmck@...nel.org>, Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH 07/14] net: bridge: replace call_rcu by kfree_rcu for
 simple kmem_cache_free callback

On 6/9/24 11:27, Julia Lawall wrote:
> Since SLOB was removed, it is not necessary to use call_rcu
> when the callback only performs kmem_cache_free. Use
> kfree_rcu() directly.
> 
> The changes were done using the following Coccinelle semantic patch.
> This semantic patch is designed to ignore cases where the callback
> function is used in another way.
> 
[snip]
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
> Reviewed-by: Paul E. McKenney <paulmck@...nel.org>
> Reviewed-by: Vlastimil Babka <vbabka@...e.cz>
> 
> ---
>  net/bridge/br_fdb.c |    9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 

Thanks,
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>