linux-kernel - Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmctTwAuzkObaXLi@google.com>
Date: Mon, 10 Jun 2024 16:43:59 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Barry Song <21cnbao@...il.com>
Cc: linaro-mm-sig@...ts.linaro.org, linux-media@...r.kernel.org,
	sumit.semwal@...aro.org, Brian.Starkey@....com,
	benjamin.gaignard@...labora.com, christian.koenig@....com,
	dri-devel@...ts.freedesktop.org, jstultz@...gle.com,
	linux-kernel@...r.kernel.org, tjmercier@...gle.com,
	v-songbaohua@...o.com, hailong.liu@...o.com
Subject: Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and
 heap_flags

On Thu, Jun 06, 2024 at 02:02:13PM +1200, Barry Song wrote:
> From: Barry Song <v-songbaohua@...o.com>
> 
> dma_heap_allocation_data defines the UAPI as follows:
> 
>  struct dma_heap_allocation_data {
>         __u64 len;
>         __u32 fd;
>         __u32 fd_flags;
>         __u64 heap_flags;
>  };
> 
> But dma heaps are casting both fd_flags and heap_flags into
> unsigned long. This patch makes dma heaps - cma heap and
> system heap have consistent types with UAPI.
> 
> Signed-off-by: Barry Song <v-songbaohua@...o.com>
> ---

Looks good to me, thanks!

Reviewed-by: Carlos Llamas <cmllamas@...gle.com>