linux-kernel - Re: [PATCH v2] checkpatch: really skip LONG_LINE_* when LONG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4e6c55e3683d72e1688751ac07a242a7e008ab7.camel@perches.com>
Date: Mon, 10 Jun 2024 10:25:29 -0700
From: Joe Perches <joe@...ches.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	linux-renesas-soc@...r.kernel.org
Cc: Andy Whitcroft <apw@...onical.com>, Dwaipayan Ray
 <dwaipayanray1@...il.com>,  Lukas Bulwahn <lukas.bulwahn@...il.com>, Andrew
 Morton <akpm@...ux-foundation.org>,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: really skip LONG_LINE_* when LONG_LINE
 is ignored

On Mon, 2024-06-10 at 17:02 +0200, Wolfram Sang wrote:
> For a printout to happen, all types must be set to "show". So, AND is needed
> for the flags, not OR, if we want to ignore something.

Right.  One day I'll learn...

As the comment above the block shows:

47e0c88b37a5c3 (Joe Perches        2015-06-25 15:02:57 -0700 3821) # if LONG_LINE is ignored, the other 2 types are also ignored

Acked-by: Joe Perches <joe@...ches.com>

> 
> Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks")
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> 
> Change since v1:
> * removed now unneeded pair of braces (Thanks, Geert!)
> * reworded commit message
> 
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b812210b412..375749e0a174 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3858,7 +3858,7 @@ sub process {
>  			}
>  
>  			if ($msg_type ne "" &&
> -			    (show_type("LONG_LINE") || show_type($msg_type))) {
> +			    show_type("LONG_LINE") && show_type($msg_type)) {
>  				my $msg_level = \&WARN;
>  				$msg_level = \&CHK if ($file);
>  				&{$msg_level}($msg_type,