[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <07b7f432-bb9a-1285-2431-0f5d2232b0eb@gmail.com>
Date: Mon, 10 Jun 2024 20:31:08 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>,
netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Martin Habets <habetsm.xilinx@...il.com>,
linux-net-drivers@....com, Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
linux-rdma@...r.kernel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>, intel-wired-lan@...ts.osuosl.org,
Louis Peens <louis.peens@...igine.com>, oss-drivers@...igine.com,
linux-kernel@...r.kernel.org, Davide Caratti <dcaratti@...hat.com>,
i.maximets@....org
Subject: Re: [PATCH net-next 2/5] sfc: use
flow_rule_is_supp_enc_control_flags()
On 09/06/2024 18:33, Asbjørn Sloth Tønnesen wrote:
> Change the existing check for unsupported encapsulation control flags,
> to use the new helper flow_rule_is_supp_enc_control_flags().
>
> No functional change, only compile tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
Acked-by: Edward Cree <ecree.xilinx@...il.com>
> ---
> drivers/net/ethernet/sfc/tc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
> index 9d140203e273a..0d93164988fc6 100644
> --- a/drivers/net/ethernet/sfc/tc.c
> +++ b/drivers/net/ethernet/sfc/tc.c
> @@ -387,11 +387,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
> struct flow_match_control fm;
>
> flow_rule_match_enc_control(rule, &fm);
> - if (fm.mask->flags) {
> - NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on enc_control.flags %#x",
> - fm.mask->flags);
> + if (flow_rule_has_enc_control_flags(fm.mask->flags, extack))
> return -EOPNOTSUPP;
> - }
> if (!IS_ALL_ONES(fm.mask->addr_type)) {
> NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported enc addr_type mask %u (key %u)",
> fm.mask->addr_type,
>
Powered by blists - more mailing lists