[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240610222103.GA3160412-robh@kernel.org>
Date: Mon, 10 Jun 2024 16:21:03 -0600
From: Rob Herring <robh@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: convert tas571x.txt to dt-schema
On Fri, Jun 07, 2024 at 11:54:35AM +0200, Neil Armstrong wrote:
> Convert the text bindings for the Texas Instruments
> TAS5711/TAS5717/TAS5719/TAS5721 stereo power amplifiers to
> dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
> .../devicetree/bindings/sound/tas571x.txt | 49 --------
> .../devicetree/bindings/sound/ti,tas57xx.yaml | 129 +++++++++++++++++++++
> 2 files changed, 129 insertions(+), 49 deletions(-)
Looks like 'port' was undocumented and should be added.
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas57xx.yaml b/Documentation/devicetree/bindings/sound/ti,tas57xx.yaml
> new file mode 100644
> index 000000000000..fa6d6c1c8535
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tas57xx.yaml
> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tas57xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 stereo power amplifiers
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@...aro.org>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tas5707
> + - ti,tas5711
> + - ti,tas5717
> + - ti,tas5719
> + - ti,tas5721
> + - ti,tas5733
> +
> + reg:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO for the active low reset line
> +
> + pdn-gpios:
> + maxItems: 1
> + description: GPIO for the active low powerdown line
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: mclk
> +
> + AVDD-supply: true
> + DVDD-supply: true
> + HPVDD-supply: true
> + PVDD_AB-supply: true
> + PVDD_CD-supply: true
> + PVDD_A-supply: true
> + PVDD_B-supply: true
> + PVDD_C-supply: true
> + PVDD_D-supply: true
> + DRVDD-supply: true
> + PVDD-supply: true
> +
> + '#sound-dai-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - '#sound-dai-cells'
> +
> +allOf:
> + - $ref: dai-common.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas5717
> + - ti,tas5719
> + then:
> + properties:
> + PVDD_A-supply: false
> + PVDD_B-supply: false
> + PVDD_C-supply: false
> + PVDD_D-supply: false
> + DRVDD-supply: false
> + PVDD-supply: false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas5711
> + then:
> + properties:
> + HPVDD-supply: false
> + PVDD_AB-supply: false
> + PVDD_CD-supply: false
> + DRVDD-supply: false
> + PVDD-supply: false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas5721
> + then:
> + properties:
> + HPVDD-supply: false
> + PVDD_AB-supply: false
> + PVDD_CD-supply: false
> + PVDD_A-supply: false
> + PVDD_B-supply: false
> + PVDD_C-supply: false
> + PVDD_D-supply: false
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
You aren't using this.
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
blank line
> + codec: codec@2a {
Drop label
> + compatible = "ti,tas5717";
> + reg = <0x2a>;
> + #sound-dai-cells = <0>;
> + reset-gpios = <&gpio1 15 0>;
> + pdn-gpios = <&gpio1 15 0>;
> + AVDD-supply = <&avdd_supply>;
> + DVDD-supply = <&dvdd_supply>;
> + HPVDD-supply = <&hpvdd_supply>;
> + PVDD_AB-supply = <&pvdd_ab_supply>;
> + PVDD_CD-supply = <&pvdd_cd_supply>;
> + };
> + };
> +
> +...
>
> ---
> base-commit: c3f38fa61af77b49866b006939479069cd451173
> change-id: 20240607-topic-amlogic-upstream-bindings-convert-tas57xx-5af1e564e6a1
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@...aro.org>
>
Powered by blists - more mailing lists