linux-kernel - Re: [PATCH 0/9] Test the consistency of AMD PMU counters and their features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gsntzfrs9xqp.fsf@coltonlewis-kvm.c.googlers.com>
Date: Mon, 10 Jun 2024 23:36:14 +0000
From: Colton Lewis <coltonlewis@...gle.com>
To: Jinrong Liang <ljr.kernel@...il.com>
Cc: seanjc@...gle.com, pbonzini@...hat.com, likexu@...cent.com, 
	jmattson@...gle.com, aaronlewis@...gle.com, wanpengli@...cent.com, 
	cloudliang@...cent.com, ljr.kernel@...il.com, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] Test the consistency of AMD PMU counters and their features

Hi Jinrong,

Sorry if this is repeating myself, but I only replied to you before
when I should have included the list.

Sean may have something useful to add as well.

Jinrong Liang <ljr.kernel@...il.com> writes:

> Hi,

> This series is an addition to below patch set:
> KVM: x86/pmu: selftests: Fixes and new tests
> https://lore.kernel.org/all/20231110021306.1269082-1-seanjc@google.com/

Since this is a few months old and v10 of Sean's patch has been applied
here [1], have you done any further work on this series? No pressure if
not, but Mingwei and I are interested in covering AMD for some PMU
testing we are working on and we want to make sure we know the latest
work.

> Add selftests for AMD PMU counters, including tests for basic  
> functionality
> of AMD PMU counters, numbers of counters, AMD PMU versions, PerfCtrExtCore
> and AMD PerfMonV2 features. Also adds PMI tests for Intel gp and fixed  
> counters.

> All patches have been tested on both Intel and AMD machines, with one  
> exception
> AMD Guest PerfMonV2 has not been tested on my AMD machine, as does not  
> support
> PerfMonV2.

> If Sean fixed the issue of not enabling forced emulation to generate #UD  
> when
> applying the "KVM: x86/pmu: selftests: Fixes and new tests" patch set,  
> then the
> patch "KVM: selftests: Add forced emulation check to fix #UD" can be  
> dropped.

> Any feedback or suggestions are greatly appreciated.

I'll happily review once my question above is answered.

> Sincerely,

> Jinrong

> Jinrong Liang (9):
>    KVM: selftests: Add forced emulation check to fix #UD
>    KVM: selftests: Test gp counters overflow interrupt handling
>    KVM: selftests: Test fixed counters overflow interrupt handling
>    KVM: selftests: Add x86 feature and properties for AMD PMU in
>      processor.h
>    KVM: selftests: Test AMD PMU performance counters basic functions
>    KVM: selftests: Test consistency of AMD PMU counters num
>    KVM: selftests: Test consistency of PMU MSRs with AMD PMU version
>    KVM: selftests: Test AMD Guest PerfCtrExtCore
>    KVM: selftests: Test AMD Guest PerfMonV2

>   .../selftests/kvm/include/x86_64/processor.h  |   3 +
>   .../selftests/kvm/x86_64/pmu_counters_test.c  | 446 ++++++++++++++++--
>   2 files changed, 400 insertions(+), 49 deletions(-)


> base-commit: c076acf10c78c0d7e1aa50670e9cc4c91e8d59b4
> prerequisite-patch-id: e33e3cd1ff495ffdccfeca5c8247dc8af9996b08
> prerequisite-patch-id: a46a885c36e440f09701b553d5b27cb53f6b660f
> prerequisite-patch-id: a9ac79bbf777b3824f0c61c45a68f1308574ab79
> prerequisite-patch-id: cd7b82618866160b5ac77199b681148dfb96e341
> prerequisite-patch-id: df5d1c23dd98d83ba3606e84eb5f0a4cd834f52c
> prerequisite-patch-id: e374d7ce66c66650f23c066690ab816f81e6c3e3
> prerequisite-patch-id: 11f133be9680787fe69173777ef1ae448b23168c
> prerequisite-patch-id: eea75162480ca828fb70395d5c224003ea5ae246
> prerequisite-patch-id: 6b7b22b6b56dd28bd80404e1a295abef60ecfa9a
> prerequisite-patch-id: 2a078271ce109bb526ded7d6eec12b4adbe26cff
> prerequisite-patch-id: e51c5c2f34fc9fe587ce0eea6f11dc84af89a946
> prerequisite-patch-id: 8c1c276fc6571a99301d18aa00ad8280d5a29faf
> prerequisite-patch-id: 37d2f2895e22bae420401e8620410cd628e4fb39
> prerequisite-patch-id: 1abba01ee49d71c38386afa9abf1794130e32a2c
> prerequisite-patch-id: a7486fd15be405a864527090d473609d44a99c3b
> prerequisite-patch-id: 41993b2eef8d1e2286ec04b3c1aa1a757792bafe
> prerequisite-patch-id: 9442b1b4c370b1a68c32eaa6ce3ee4c5d549efd0
> prerequisite-patch-id: 89b2e89917a89713d6a63cbd594f6979f4d06578
> prerequisite-patch-id: 1e9fe564790f41cfd52ebafc412434608187d8db
> prerequisite-patch-id: 7d0b2b4af888fe09eae85ebfe56b4daed71aa08c
> prerequisite-patch-id: 4e6910c90ae769b7556f6aec40f5d600285fe4d0
> prerequisite-patch-id: 5248bc19b00c94188b803a4f41fa19172701d7b0
> prerequisite-patch-id: f9310c716dbdcbe9e3672e29d9e576064845d917
> prerequisite-patch-id: 21b2c6b4878d2ce5a315627efa247240335ede1e
> prerequisite-patch-id: e01570f8ff40aacba38f86454572803bd68a1d59
> prerequisite-patch-id: 65eea4f11ce5e8f9836651c593b7e563b0404459

[1]  
https://lore.kernel.org/kvm/170666267480.3861961.1911322891711579495.b4-ty@google.com/