linux-kernel - Re: [PATCH] drivers: nvme: target: core: deref after null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 08:54:43 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Alexandr Sapozhnikov <alsp705@...il.com>, linux-nvme@...ts.infradead.org,
 lvc-project@...uxtesting.org, Chaitanya Kulkarni <kch@...dia.com>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: nvme: target: core: deref after null

> After having been compared to a NULL value at core.c:813,
> pointer '(**sq->ctrl).sqs' is dereferenced at core.c:838.

* Please choose another imperative wording for an improved change description.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94

* Would you like to add the tag “Fixes” accordingly?

* How do you think about to use the summary phrase “Avoid null pointer dereference
  in nvmet_sq_destroy()”?

* Is the subsystem specification “nvmet” more appropriate?

Regards,
Markus